Of those two, I would take the
246. While the 250 is a good scanner (I have one), it will not be supported through rebanding, which is on the horizon in the next year or two. The 246 will be supported. It's a good scanner. Nice convenient pocket size.
If you are interested in military aircraft comms as well, keep an eye out for a deal on a
BR330T. It's the next step up from the 246. While it has the NASCAR logo on it, I bought one for the wideband coverage, not because of a sticker.
Neither the 246 nor the 330 will handle digital. Looks like most of
NYC itself is still analog, with the exception of a couple of channels used for high rise fires (they are labeled APCO-25). The Federal agencies are mostly digital. But going digital, you'd add $250 or more to your costs. The 246 starts at about $215 new from online sources (just the scanner, antenna, ac adapter, & pc programming cable). The 330 is about $50 more. Programming software is available at additional cost (but not required) for either scanner, as are different aftermarket antennas, tailored for specific bands.
Depending on age & condition, & whether it comes with extra cost options like software or a case, a used unit can save you anywhere from $25 to 75 over the cost of the same package if purchased new (sometimes more).